Re: [RFC 3/9] PCI/portdrv: create platform devices for child OF nodes
flat view
From: Rob Herring <robh+dt@kernel.org>
Date: 2024-01-17 23:39:01
Also in:
linux-arm-msm, linux-devicetree, linux-pci, linux-wireless, lkml, netdev
On Fri, Jan 12, 2024 at 3:43 AM Lukas Wunner [off-list ref] wrote:
On Thu, Jan 11, 2024 at 05:16:45PM +0100, Bartosz Golaszewski wrote:quoted
On Thu, Jan 11, 2024 at 4:02???PM Lukas Wunner [off-list ref] wrote:quoted
On Wed, Jan 10, 2024 at 05:26:52PM +0100, Bartosz Golaszewski wrote:quoted
if (pci_is_bridge(dev)) of_pci_make_dev_node(dev);But perhaps of_pci_make_dev_node() returns immediately because:No, it was actually a no-op due to CONFIG_PCI_DYNAMIC_OF_NODES not being set. But this is only available if CONFIG_OF_DYNAMIC is enabled which requires OF_UNITTEST (!). We definitely don't need to enable dynamic OF nodes. We don't want to modify the DT, we want to create devices for existing nodes.Consider refactoring of_pci_make_dev_node() to suit your needs or add a separate function call inside the "if (pci_is_bridge(dev))" clause which populates the child OF nodes.
The latter because of_pci_make_dev_node() has absolutely nothing to do with the issue this series solves. The uses are pretty much mutually exclusive. If we have a DT node with power related properties, there is no need to create that node because it already exists. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel