Re: [PATCH v12 2/3] dt-bindings: hwmon: Support Aspeed g6 PWM TACH Control
From: Krzysztof Kozlowski <hidden>
Date: 2024-01-15 07:56:31
Also in:
linux-aspeed, linux-devicetree, linux-doc, linux-hwmon, linux-pwm, lkml
On 15/01/2024 08:05, Billy Tsai wrote:
quoted
quoted
+examples: + - | + #include <dt-bindings/clock/aspeed-clock.h> + pwm_tach: pwm-tach-controller@1e610000 { + compatible = "aspeed,ast2600-pwm-tach"; + reg = <0x1e610000 0x100>; + clocks = <&syscon ASPEED_CLK_AHB>; + resets = <&syscon ASPEED_RESET_PWM>; + #pwm-cells = <3>; + + fan-0 { + tach-ch = /bits/ 8 <0x0>; + }; + + fan-1 { + tach-ch = /bits/ 8 <0x1 0x2>; + };quoted
NAK on this based on how you are using pwm-fan in v10 discussion. See my comments there.Okay, I will merge everything from the pwm-fan0 node into the fan-0 node and add the 'simple-bus' to the compatible string of the pwm_tach node.
What simple-bus has anything to do with it? This is not a bus. Just to remind: we talk about bindings, not driver. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel