Thread (8 messages) 8 messages, 3 authors, 2024-01-09

Re: [PATCH 12/12] mailbox: zynqmp-ipi: Convert to platform remove callback returning void

From: Michal Simek <michal.simek@amd.com>
Date: 2024-01-02 09:36:19
Also in: lkml


On 12/27/23 22:02, Uwe Kleine-König wrote:
quoted hunk ↗ jump to hunk
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <redacted>
---
  drivers/mailbox/zynqmp-ipi-mailbox.c | 6 ++----
  1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c
index 7fa533e80dd9..610a92f9c0b2 100644
--- a/drivers/mailbox/zynqmp-ipi-mailbox.c
+++ b/drivers/mailbox/zynqmp-ipi-mailbox.c
@@ -688,19 +688,17 @@ static int zynqmp_ipi_probe(struct platform_device *pdev)
  	return ret;
  }
  
-static int zynqmp_ipi_remove(struct platform_device *pdev)
+static void zynqmp_ipi_remove(struct platform_device *pdev)
  {
  	struct zynqmp_ipi_pdata *pdata;
  
  	pdata = platform_get_drvdata(pdev);
  	zynqmp_ipi_free_mboxes(pdata);
-
-	return 0;
  }
  
  static struct platform_driver zynqmp_ipi_driver = {
  	.probe = zynqmp_ipi_probe,
-	.remove = zynqmp_ipi_remove,
+	.remove_new = zynqmp_ipi_remove,
  	.driver = {
  		   .name = "zynqmp-ipi",
  		   .of_match_table = of_match_ptr(zynqmp_ipi_of_match),
Reviewed-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help