Re: [PATCH v5 04/16] dt-bindings: imx6q-pcie: Add linux,pci-domain as required for iMX8MQ
From: Krzysztof Kozlowski <hidden>
Date: 2023-12-24 09:02:32
Also in:
imx, linux-devicetree, linux-pci, lkml
On 24/12/2023 05:29, Frank Li wrote:
On Sat, Dec 23, 2023 at 07:40:28PM +0100, Krzysztof Kozlowski wrote:quoted
On 20/12/2023 22:36, Frank Li wrote:quoted
iMX8MQ have two pci controllers. Adds "linux,pci-domain" as required proptery for iMX8MQ to indicate pci controller index.Why it has to be required? Everything will work fine if skipped. Otherwise please provide reason why it must be *required*.Next patch will use "linux,pci-domain" as PCI slot ID, instead compared with hard code register address. The below code will be removed. - if (dbi_base->start == IMX8MQ_PCIE2_BASE_ADDR) - imx6_pcie->controller_id = 1; when there are more than 2 controller, this compare logic will become complex. So after next patch, "linux,pci-domain" will be required.
Nothing in commit msg explains this. Why you cannot use some auto-incremented values when this is missing? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel