Re: [PATCH v3 08/14] ARM: dts: aspeed: yosemite4: Revise i2c11 and i2c12 schematic change
From: Krzysztof Kozlowski <hidden>
Date: 2023-12-13 07:20:36
Also in:
linux-aspeed, linux-devicetree, lkml
On 11/12/2023 06:47, Delphine CC Chiu wrote:
Revise i2c11 and i2c12 schematic change: - remove space for adm1272 compatible - enable interrupt setting for pca9555 - add eeprom for yosemite4 medusa board/BSM use - remove temperature sensor for yosemite4 schematic change - add power sensor for power module reading
Way too many changes in one patch. Especially mixing fixes and new features is bad. Please don't.
quoted hunk ↗ jump to hunk
Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com> --- .../aspeed/aspeed-bmc-facebook-yosemite4.dts | 118 ++++++++++++++---- 1 file changed, 93 insertions(+), 25 deletions(-)diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts index da413325ce30..ccb5ecd8d9a6 100644 --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts@@ -821,41 +821,94 @@ imux29: i2c@1 { &i2c11 { status = "okay"; power-sensor@10 { - compatible = "adi, adm1272"; + compatible = "adi,adm1272"; reg = <0x10>; }; power-sensor@12 { - compatible = "adi, adm1272"; + compatible = "adi,adm1272"; reg = <0x12>; }; - gpio@20 { + gpio_ext1: pca9555@20 {
That's wrong name.
compatible = "nxp,pca9555";
- reg = <0x20>;
+ pinctrl-names = "default";
gpio-controller;
#gpio-cells = <2>;
- };
-
- gpio@21 {
+ reg = <0x20>;
+ interrupt-parent = <&gpio0>;
+ interrupts = <94 IRQ_TYPE_LEVEL_LOW>;
+ gpio-line-names =
+ "P48V_OCP_GPIO1","P48V_OCP_GPIO2",
+ "P48V_OCP_GPIO3","FAN_BOARD_0_REVISION_0_R",
+ "FAN_BOARD_0_REVISION_1_R","FAN_BOARD_1_REVISION_0_R",
+ "FAN_BOARD_1_REVISION_1_R","RST_MUX_R_N",
+ "RST_LED_CONTROL_FAN_BOARD_0_N","RST_LED_CONTROL_FAN_BOARD_1_N",
+ "RST_IOEXP_FAN_BOARD_0_N","RST_IOEXP_FAN_BOARD_1_N",
+ "PWRGD_LOAD_SWITCH_FAN_BOARD_0_R","PWRGD_LOAD_SWITCH_FAN_BOARD_1_R",
+ "","";
+ };
+
+ gpio_ext2: pca9555@21 {Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
compatible = "nxp,pca9555";
- reg = <0x21>;
+ pinctrl-names = "default";
gpio-controller;
#gpio-cells = <2>;
- };
-
- gpio@22 {
+ reg = <0x21>;
+ interrupt-parent = <&gpio0>;
+ interrupts = <94 IRQ_TYPE_LEVEL_LOW>;
+ gpio-line-names =
+ "DELTA_MODULE_TYPE","VSENSE_ERR_VDROP_R",
+ "EN_P48V_AUX_0","EN_P48V_AUX_1",
+ "MEDUSA_BOARD_REV_0","MEDUSA_BOARD_REV_1",
+ "MEDUSA_BOARD_REV_2","MEDUSA_BOARD_TYPE",
+ "HSC_OCP_SLOT_ODD_GPIO1","HSC_OCP_SLOT_ODD_GPIO2",
+ "HSC_OCP_SLOT_ODD_GPIO3","HSC_OCP_SLOT_EVEN_GPIO1",
+ "HSC_OCP_SLOT_EVEN_GPIO2","HSC_OCP_SLOT_EVEN_GPIO3",
+ "ADC_TYPE_0_R","ADC_TYPE_1_R";
+ };
+
+ gpio_ext3: pca9555@22 {Please fix it everywhere. In this patch and all your future patches. I keep repeating the same feedback... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel