Re: [PATCH v7 2/3] dt-bindings: arm64: add Marvell COM Express boards
From: Conor Dooley <conor@kernel.org>
Date: 2023-12-07 17:13:06
Also in:
linux-devicetree, lkml
On Thu, Dec 07, 2023 at 04:32:47PM +0200, Elad Nachman wrote:
quoted hunk
From: Elad Nachman <enachman@marvell.com> Add dt bindings for: CN9130 COM Express CPU module CN9131 COM Express CPU module AC5X RD COM Express Type 7 carrier board. AC5X RD COM Express board with a CN9131 COM Express Type 7 CPU module. Signed-off-by: Elad Nachman <enachman@marvell.com> --- .../bindings/arm/marvell/armada-7k-8k.yaml | 24 +++++++++++++++++++ 1 file changed, 24 insertions(+)diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml index 52d78521e412..d00866aeaa8d 100644 --- a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml +++ b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml@@ -60,4 +60,28 @@ properties: - const: marvell,armada-ap807-quad - const: marvell,armada-ap807 + - description: + Alleycat5X (98DX35xx) Reference Design as COM Express Carrier plus + Armada CN9130 COM Express CPU module + items: + - enum: + - marvell,cn9130-ac5x-carrier
There's so many compatibles here that it is a bit hard for me to follow, but I am wondering why you have the "enum" here. The description seems to define this as being for one specific carrier and you have two entries here for carriers compatible with the rd-ac5x. It looks like you should either a) combine both of these or b) swap the enum for const. Thanks, Conor.
+ - const: marvell,rd-ac5x-carrier + - const: marvell,cn9130-cpu-module + - const: marvell,cn9130 + - const: marvell,armada-ap807-quad + - const: marvell,armada-ap807 + + - description: + Alleycat5X (98DX35xx) Reference Design as COM Express Carrier plus + Armada CN9131 COM Express CPU module + items: + - enum: + - marvell,cn9131-ac5x-carrier + - const: marvell,rd-ac5x-carrier + - const: marvell,cn9131-cpu-module + - const: marvell,cn9131 + - const: marvell,armada-ap807-quad + - const: marvell,armada-ap807 + additionalProperties: true -- 2.25.1