Re: [PATCH] i2c: rk3x: fix potential spinlock recursion on poll
From: Andi Shyti <andi.shyti@kernel.org>
Date: 2023-12-06 12:27:56
Also in:
linux-i2c, linux-rockchip, lkml
Hi Jensen, On Wed, Dec 06, 2023 at 05:06:40PM +0800, Jensen Huang wrote:
Possible deadlock scenario (on reboot):
rk3x_i2c_xfer_common(polling)
-> rk3x_i2c_wait_xfer_poll()
-> rk3x_i2c_irq(0, i2c);
--> spin_lock(&i2c->lock);
...
<rk3x i2c interrupt>
-> rk3x_i2c_irq(0, i2c);
--> spin_lock(&i2c->lock); (deadlock here)
Store the IRQ number and disable/enable it around the polling transfer.
This patch has been tested on NanoPC-T4.
Signed-off-by: Jensen Huang <redacted>Looks good, Reviewed-by: Andi Shyti <andi.shyti@kernel.org> Thanks, Andi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel