Thread (48 messages) 48 messages, 7 authors, 2023-12-07

Re: [PATCH v4 12/23] pinctrl: mediatek: Make use of PINCTRL_GROUP_DESC()

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2023-12-04 13:32:40
Also in: linux-arm-msm, linux-gpio, linux-mediatek, linux-mips, linux-renesas-soc, lkml

On Mon, Dec 04, 2023 at 02:19:10PM +0100, Geert Uytterhoeven wrote:
Hi Andy,

On Mon, Dec 4, 2023 at 2:10 PM Andy Shevchenko
[off-list ref] wrote:
quoted
On Mon, Dec 04, 2023 at 12:40:38PM +0100, Marek Szyprowski wrote:
quoted
On 29.11.2023 17:06, Andy Shevchenko wrote:
quoted
Make use of PINCTRL_GROUP_DESC() instead of open coding it.
quoted
PINCTRL_GROUP_DESC() macro from drivers/pinctrl/core.h contains a cast
to (struct group_desc), what breaks users of the above macros.
There is no cast (*).
Thanks for report, I will check.

But this was v4 of the series and LKP actually sent a positive feedback.
Besides that I have tested this locally with modules enabled.

*) It's a compound literal, _not_ a cast.
   Taking above into consideration I'm wondering what compilers
   are in use?
kisskb reported the following m68k failures to me:
    linux-next/m68k-allmodconfig/m68k-gcc8
    linux-next/m68k-allmodconfig/m68k-gcc11
    linux-next/m68k-allmodconfig/m68k-gcc12

However, according to [1], linux-next/m68k-allmodconfig/m68k-gcc13
did succeed, so I guess you are using gcc13?
Yes, I compiled with these:

$ gcc --version
gcc (Debian 13.2.0-5) 13.2.0
Copyright (C) 2023 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

$ clang --version
Debian clang version 16.0.6 (16)
	Target: x86_64-pc-linux-gnu
	Thread model: posix
	InstalledDir: /usr/bin


-- 
With Best Regards,
Andy Shevchenko



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help