Re: [PATCH 7/7] dma-mapping: Simplify arch_setup_dma_ops()

From
Robin Murphy <robin.murphy@arm.com>
Date
2023-12-04 12:55:03
Also in
linux-acpi, linux-devicetree, linux-iommu, lkml
Reply to
Christoph Hellwig, 2023-12-04
On 04/12/2023 8:44 am, Christoph Hellwig wrote:
On Wed, Nov 29, 2023 at 05:43:04PM +0000, Robin Murphy wrote:
quoted
The dma_base, size and iommu arguments are only used by ARM, and can
now easily be deduced from the device itself, so there's no need to pass
them through the callchain as well.
This looks even better than the patch form Jason that only removed the
iommu argument:

Reviewed-by: Christoph Hellwig <hch@lst.de>

I wonder if it makes sense to also remove the coherent argument
by setting up dev->dma_coherent in the caller.  That would require
a pretty careful audit as we're doing a few weird things in that
area, though.
Yeah, it crossed my mind too, but then I remembered we have at least the ARM stuff which may have already set a platform-specific value for dev->dma_coherent to take precedence over the firmware value, thus still needs to differentiate between the two at this point. Leaving the established argument in place seems neater IMO than having to go back to arch-specific mechanisms for that and any other similar tricks.

Thanks,
Robin.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Thread (29 messages) 29 messages, 6 authors, last reply 2023-12-11
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help