Re: [PATCH RFC 10/22] drivers: base: Move cpu_dev_init() after node_dev_init()
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Date: 2023-11-28 15:00:26
Also in:
kvmarm, linux-acpi, linux-arch, linux-doc, linux-pm, linux-riscv, lkml, loongarch
On Tue, 28 Nov 2023 13:55:36 +0000 Jonathan Cameron [off-list ref] wrote:
On Tue, 21 Nov 2023 13:27:08 +0000 "Russell King (Oracle)" [off-list ref] wrote:quoted
On Mon, Nov 13, 2023 at 08:00:19AM +0000, Russell King (Oracle) wrote:quoted
On Mon, Nov 13, 2023 at 10:58:46AM +1000, Gavin Shan wrote:quoted
On 11/7/23 20:30, Russell King (Oracle) wrote:quoted
From: James Morse <james.morse@arm.com> NUMA systems require the node descriptions to be ready before CPUs are registered. This is so that the node symlinks can be created in sysfs. Currently no NUMA platform uses GENERIC_CPU_DEVICES, meaning that CPUs are registered by arch code, instead of cpu_dev_init(). Move cpu_dev_init() after node_dev_init() so that NUMA architectures can use GENERIC_CPU_DEVICES. Signed-off-by: James Morse <james.morse@arm.com> Signed-off-by: Russell King (Oracle) <redacted> --- Note: Jonathan's comment still needs addressing - see https://lore.kernel.org/r/20230914121612.00006ac7@Huawei.com (local) --- drivers/base/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)With Jonathan's comments addressed:That needs James' input, which is why I made the note on the patch.I'm going to be posting the series without RFC soon, and it will be with Jonathan's comment unaddressed - because as I've said several times it needs James' input and we have sadly not yet received that. Short of waiting until James can respond, I don't think there are any other alternatives.In the interests of expediency I'm fine with that. (To be honest I'd forgotten I even made that comment ;)
Given what I was looking for was a 'nice to have' extra bit of info in the patch description and I'm fine with the actual change even without that: Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Jonathanquoted
I do hope we can get this queued up for v6.8 though.
*fingers crossed* !
quoted
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel