Re: [PATCH] fpga: zynq: Fix incorrect variable type
From: Xu Yilun <hidden>
Date: 2023-11-09 08:06:42
Also in:
linux-fpga, lkml
On Thu, Nov 09, 2023 at 11:58:23AM +0530, Nava kishore Manne wrote:
From: Nava kishore Manne <redacted> zynq_fpga_has_sync () API is expecting "u8 *" but the formal parameter that was passed is of type "const char *". To fix this issue cast the const char pointer to u8 pointer.
Any error log found? I assume this is just implicit cast and doesn't worth a fix. Thanks, Yilun
quoted hunk ↗ jump to hunk
Signed-off-by: Nava kishore Manne <redacted> --- drivers/fpga/zynq-fpga.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c index 96611d424a10..988853137ac6 100644 --- a/drivers/fpga/zynq-fpga.c +++ b/drivers/fpga/zynq-fpga.c@@ -275,7 +275,7 @@ static int zynq_fpga_ops_write_init(struct fpga_manager *mgr, /* don't globally reset PL if we're doing partial reconfig */ if (!(info->flags & FPGA_MGR_PARTIAL_RECONFIG)) { - if (!zynq_fpga_has_sync(buf, count)) { + if (!zynq_fpga_has_sync((u8 *)buf, count)) { dev_err(&mgr->dev, "Invalid bitstream, could not find a sync word. Bitstream must be a byte swapped .bin file\n"); err = -EINVAL;-- 2.25.1
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel