Re: [PATCH V2 3/5] arm64: zynqmp: Add ZynqnMP nvmem nodes
From: Krzysztof Kozlowski <hidden>
Date: 2023-10-19 09:27:49
Also in:
linux-devicetree, lkml
On 19/10/2023 08:06, Praveen Teja Kundanala wrote:
quoted hunk ↗ jump to hunk
Add nvmem DT nodes for ZynqMP SOC Signed-off-by: Praveen Teja Kundanala <praveen.teja.kundanala@amd.com> --- arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 59 +++++++++++++++++++++++++- 1 file changed, 57 insertions(+), 2 deletions(-)diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi index b61fc99cd911..b7433e6b9d6c 100644 --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi@@ -194,14 +194,69 @@ zynqmp_power: zynqmp-power { mbox-names = "tx", "rx"; }; - nvmem_firmware { + nvmem-firmware {
Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
compatible = "xlnx,zynqmp-nvmem-fw";
It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ for instructions).
#address-cells = <1>;
#size-cells = <1>;
- soc_revision: soc_revision@0 {
+ soc_revision: soc-revision@0 {
reg = <0x0 0x4>;
};Wasn't this fixed already by Michal? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel