Re: [PATCH net-next v11 0/6] introduce page_pool_alloc() related API
From: Jakub Kicinski <kuba@kernel.org>
Date: 2023-10-17 15:13:10
Also in:
bpf, linux-mediatek, lkml, netdev
From: Jakub Kicinski <kuba@kernel.org>
Date: 2023-10-17 15:13:10
Also in:
bpf, linux-mediatek, lkml, netdev
On Tue, 17 Oct 2023 15:56:48 +0800 Yunsheng Lin wrote:
quoted
And I can't figure out now what the "cache" in the name is referring to. Looks like these are just convenience wrappers which return VA instead of struct page..Yes, it is corresponding to some API like napi_alloc_frag() returning va instead of 'struct page' mentioned in patch 5. Anyway, naming is hard, any suggestion for a better naming is always welcomed:)
I'd just throw a _va (for virtual address) at the end. And not really mention it in the documentation. Plus the kdoc of the function should say that this is just a thin wrapper around other page pool APIs, and it's safe to mix it with other page pool APIs? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel