RE: [PATCH v8 1/5] dt-bindings: media: platform: visconti: Add Toshiba Visconti Video Input Interface

Hello Krzysztof,

-----Original Message-----
From: Krzysztof Kozlowski <redacted>
Sent: Wednesday, October 4, 2023 3:51 PM
To: ishikawa yuji(石川 悠司 ○ＲＤＣ□ＡＩＴＣ○ＥＡ開)
[off-list ref]; hverkuil@xs4all.nl;
laurent.pinchart@ideasonboard.com; mchehab@kernel.org;
robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org;
iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□ＤＩＴ○ＯＳＴ)
[off-list ref]
Cc: linux-media@vger.kernel.org; devicetree@vger.kernel.org;
linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 1/5] dt-bindings: media: platform: visconti: Add Toshiba
Visconti Video Input Interface

On 04/10/2023 01:10, yuji2.ishikawa@toshiba.co.jp wrote:

quoted

quoted

quoted

+    properties:
+      endpoint:
+        $ref: video-interfaces.yaml#
+        additionalProperties: false

This is a friendly reminder during the review process.

It seems my previous comments were not fully addressed. Maybe my
feedback got lost between the quotes, maybe you just forgot to apply it.
Please go back to the previous discussion and either implement all
requested changes or keep discussing them.

Thank you.

I'm very sorry that I misunderstood the intent of the last conversion.
https://lore.kernel.org/all/0aa471ce-da83-172d-d870-1ec7a562baf7@linar
o.org/ I thought "additionalProperties: false" can be used and
"xxx:true" should stay.

Let me confirm your intentions:
  - "unevaluatedProperties: false" should be used instead of

"additionalProperties: false"

quoted

  - All of "xxx: true" should be removed Are these two correct
understandings?

Ah, true, I missed that. It is indeed fine, apologies.

I understand. I'll use "additionalProperties: false".

quoted

quoted

quoted

+
+        properties:
+          data-lanes:
+            description: VIIF supports 1, 2, 3 or 4 data lanes
+            minItems: 1
+            items:
+              - const: 1
+              - const: 2
+              - const: 3
+              - const: 4
+
+          clock-noncontinuous: true

Drop

This and further can be ignored.

I'll keep "xxx: true".

Best regards,
Krzysztof

Best regards,
Yuji
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel