Thread (16 messages) 16 messages, 6 authors, 2023-10-04

Re: [PATCH V3 2/3] arm64: dts: imx8mp: Add micfil node

From: Fabio Estevam <festevam@gmail.com>
Date: 2023-10-04 01:12:35
Also in: linux-clk, linux-devicetree, lkml

Hi Adam and devicetree folks,

On Thu, Aug 31, 2023 at 1:44 AM Adam Ford [off-list ref] wrote:
quoted hunk ↗ jump to hunk
The i.MX8MP has a micfil controller which is used for interfacing
with a pulse density microphone. Add the node and mark it as
disabled by default.

Signed-off-by: Adam Ford <redacted>
---
V3:  The AUDIOMIX_PDM_ROOT doesn't exist and the real clock is
     called IMX8MP_CLK_AUDIOMIX_PDM_SEL, so swap it out.

V2:  No change
diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index 3167706d81e1..341fd0369ce9 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -1479,6 +1479,27 @@ easrc: easrc@30c90000 {
                                        fsl,asrc-format = <2>;
                                        status = "disabled";
                                };
+
+                               micfil: audio-controller@30ca0000 {
+                                       compatible = "fsl,imx8mp-micfil";
+                                       reg = <0x30ca0000 0x10000>;
+                                       #sound-dai-cells = <0>;
After this patch, the following schema warning is seen:

imx8mp-beacon-kit.dtb: audio-controller@30ca0000: '#sound-dai-cells'
does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/sound/fsl,micfil.yaml#

What is the correct way to solve this?

- Document #sound-dai-cells in fsl,micfil.yaml as an optional property
- Remove #sound-dai-cells from imx8mp.dtsi
- Document #sound-dai-cells in fsl,micfil.yaml as a required property
and pass #sound-dai-cells to imx8mm/imx8mn/imx83.dtsi?

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help