Re: [PATCH v4 4/4] firmware: arm_scmi: Add qcom hvc/shmem transport support
From: Brian Masney <bmasney@redhat.com>
Date: 2023-10-02 18:40:02
Also in:
linux-arm-msm, linux-devicetree, lkml
On Mon, Oct 02, 2023 at 02:34:06PM -0400, Brian Masney wrote:
On Mon, Sep 11, 2023 at 12:43:59PM -0700, Nikunj Kela wrote:quoted
+ func_id = readl((void __iomem *)(scmi_info->shmem) + size - 16); +#ifdef CONFIG_ARM64 + cap_id = readq((void __iomem *)(scmi_info->shmem) + size - 8); +#else + /* capability-id is 32 bit wide on 32bit machines */ + cap_id = readl((void __iomem *)(scmi_info->shmem) + size - 8); +#endifThe 32 bit case is defined as a u64 in two places above.
Also should the 32 bit case be 'size - 4' instead of 'size - 8'? Sorry I just noticed that as soon as I pressed send. Brian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel