Re: [PATCH 6/8] arm64: dts: qcom: ipq5332: Add Super-Speed UNIPHY in USB node
From: Dmitry Baryshkov <hidden>
Date: 2023-09-30 17:27:42
Also in:
linux-arm-msm, linux-devicetree, linux-phy, linux-usb, lkml
On 29/09/2023 11:42, Praveenkumar I wrote:
quoted hunk ↗ jump to hunk
Add UNIPHY node in USB to support Super-speed. As the SS PHY has pipe clock, removed "qcom,select-utmi-as-pipe-clk" flag. Signed-off-by: Praveenkumar I <redacted> --- arch/arm64/boot/dts/qcom/ipq5332.dtsi | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi index 1813b9fa4bb5..8fe4e45bfc18 100644 --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi@@ -349,8 +349,6 @@ usb: usb@8af8800 { resets = <&gcc GCC_USB_BCR>; - qcom,select-utmi-as-pipe-clk; - #address-cells = <1>; #size-cells = <1>; ranges;@@ -363,8 +361,8 @@ usb_dwc: usb@8a00000 { clocks = <&gcc GCC_USB0_MOCK_UTMI_CLK>; clock-names = "ref"; interrupts = <GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH>; - phy-names = "usb2-phy"; - phys = <&usbphy0>; + phy-names = "usb2-phy", "usb3-phy"; + phys = <&usbphy0>, <&usbphy1>;
Ah, I see now. Maybe usbphy_ss_0 or something like that would be a better label for this PHY. I'd expect usbphy1 to be used for other host than usbphy0.
tx-fifo-resize; snps,is-utmi-l1-suspend; snps,hird-threshold = /bits/ 8 <0x0>;
-- With best wishes Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel