Re: [PATCH RESEND v5 7/8] arm64: dts: Add DTS for Marvell PXA1908 and samsung,coreprimevelte
From: Linus Walleij <hidden>
Date: 2023-09-29 22:05:59
Also in:
linux-clk, linux-devicetree, linux-gpio, linux-hardening, lkml, phone-devel
On Fri, Sep 29, 2023 at 5:42 PM Duje Mihanović [off-list ref] wrote:
Add DTS for Marvell PXA1908 SoC and Samsung Galaxy Core Prime Value Edition LTE, a smartphone based on said SoC. Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr>
(...)
+&pmx {
+ pinctrl-single,gpio-range = <&range 55 55 0>,
+ <&range 110 32 0>,
+ <&range 52 1 0>;
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&board_pins_1 &board_pins_2 &board_pins_3>;
+
+ board_pins_1: pinmux-board-1 {
+ pinctrl-single,pins = <
+ 0x160 0
+ 0x164 0
+ 0x168 0
+ 0x16c 0
+ >;
+ pinctrl-single,drive-strength = <0x1000 0x1800>;
+ pinctrl-single,bias-pullup = <0x8000 0x8000 0 0xc000>;
+ pinctrl-single,bias-pulldown = <0x8000 0x8000 0 0xa000>;
+ pinctrl-single,input-schmitt = <0 0x30>;
+ pinctrl-single,input-schmitt-enable = <0x40 0 0x40 0x40>;
+ pinctrl-single,low-power-mode = <0x288 0x388>;
+ };(...)
+ pmx: pinmux@1e000 {
+ compatible = "pinconf-single";At least add a new binding for "marvell,pxa1908-padconf" and use that like this: compatible = "marvell,pxa1908-padconf", "pinconf-single"; When you use pinctrl-single you get the slightly opaque device trees as seen above, so it's not something I'd recommend, I'd rather write my own pin controller. But it exists, so I can't say you can't use it. Not my choice. I understand it is convenient. It is possible to switch later, but only if you have a unique pin controller compatible so please add that. Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel