Thread (17 messages) 17 messages, 3 authors, 2023-09-18

Re: [PATCH v3 2/7] iommu: Decouple iommu_present() from bus ops

From: Jason Gunthorpe <jgg@nvidia.com>
Date: 2023-09-18 23:25:28
Also in: linux-iommu, lkml

On Mon, Sep 18, 2023 at 08:21:45PM +0100, Robin Murphy wrote:
quoted
? It doesn't seem to use the iommu API so I guess all it is doing is
trying to fix some kind of probe ordering issue? Maybe the probe
ordering issue is already gone and we can just delete the check?
As I've said before, the correct fix for this one is [1]. I've sent it twice
now, it just gets ignored :(
IMHO at this point just put it in this series and have Joerg take it
:(
Hmm, I guess maybe I did get a bit hung up on the bus notion... Indeed I
think this wouldn't really be any more inaccurate than the current
behaviour, and might be arguably truer to the intent of the function
(whatever that is) since in the new design any instance is effectively
present for all relevant buses anyway. I've respun along these lines (but
retaining the argument with some token validation) and I don't hate it, so
I'll send that as v4.
Eventually tegra is going to need to pass in a real struct device to
get the domain, so at that moment we can switch it to use the device
API on that real struct device. So this definately seems good enough
for now.

Jason

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help