Re: [PATCH 2/2] ARM: dts: aspeed: Minerva: Add Facebook Minerva CMC board

Krzysztof Kozlowski [off-list ref] 於 2023年9月13日 週三 下午6:04寫道：

On 12/09/2023 16:05, yangchen.openbmc@gmail.com wrote:

quoted

From: Yang Chen <redacted>

Add linux device tree entry related to the Minerva Chassis Management
Controller (CMC) specific devices connected to the Aspeed SoC (AST2600).

Signed-off-by: Yang Chen <redacted>
---
 arch/arm/boot/dts/aspeed/Makefile             |   1 +
 .../aspeed-bmc-facebook-minerva-cmc.dts       | 265 ++++++++++++++++++
 2 files changed, 266 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-minerva-cmc.dts

diff --git a/arch/arm/boot/dts/aspeed/Makefile b/arch/arm/

quoted

+
+&i2c15 {
+     status = "okay";
+
+     eeprom@50 {
+             compatible = "atmel,24c128";
+             reg = <0x50>;
+     };
+};
+
+&adc0 {
+     ref_voltage = <2500>;

There is no such property in the bindings.

Thanks for your advice, I will change this property to
"aspeed,int-vref-microvolt" which is defined in the binding in the v2
patch.

quoted

+     status = "okay";
+     pinctrl-0 = <&pinctrl_adc0_default &pinctrl_adc1_default
+             &pinctrl_adc2_default &pinctrl_adc3_default
+             &pinctrl_adc4_default &pinctrl_adc5_default
+             &pinctrl_adc6_default &pinctrl_adc7_default>;
+};
+
+&adc1 {
+     ref_voltage = <2500>;

NAK, there is no such property.

Thanks for your advice, I will change this property to
"aspeed,int-vref-microvolt" which is defined in the binding in the v2
patch.

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel