Hi Rob,

-----Original Message-----
From: Rob Herring <robh@kernel.org>
Sent: Monday, September 4, 2023 11:53 AM
To: Linu Cherian <redacted>
Cc: linux-arm-kernel@lists.infradead.org; mike.leach@linaro.org; Sunil
Kovvuri Goutham [off-list ref]; james.clark@arm.com;
leo.yan@linaro.org; linux-kernel@vger.kernel.org;
krzysztof.kozlowski+dt@linaro.org; George Cherian
[off-list ref]; suzuki.poulose@arm.com;
coresight@lists.linaro.org; devicetree@vger.kernel.org;
conor+dt@kernel.org; robh+dt@kernel.org
Subject: [EXT] Re: [RFC PATCH v3 1/7] dt-bindings: arm: coresight-tmc: Add
"memory-region" property

External Email

----------------------------------------------------------------------

On Mon, 04 Sep 2023 10:35:41 +0530, Linu Cherian wrote:

quoted

memory-region 0: Reserved trace buffer memory

  TMC ETR: When available, use this reserved memory region for
  trace data capture. Same region is used for trace data
  retention after a panic or watchdog reset.

  TMC ETF: When available, use this reserved memory region for
  trace data retention synced from internal SRAM after a panic or
  watchdog reset.

memory-region 1: Reserved meta data memory

  TMC ETR, ETF: When available, use this memory for register
  snapshot retention synced from hardware registers after a panic
  or watchdog reset.

Signed-off-by: Linu Cherian <redacted>
---
 .../devicetree/bindings/arm/arm,coresight-tmc.yaml  | 13
+++++++++++++
 1 file changed, 13 insertions(+)

My bot found errors running 'make DT_CHECKER_FLAGS=-m
dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml:104:4:
[error] syntax error: expected <block end>, but found '<block mapping
start>' (syntax)
./Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml:105:5:
[warning] wrong indentation: expected 5 but found 4 (indentation)

dtschema/dtc warnings/errors:
make[2]: *** Deleting file
'Documentation/devicetree/bindings/arm/arm,coresight-tmc.example.dts'
Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml:104:4: did
not find expected key
make[2]: *** [Documentation/devicetree/bindings/Makefile:26:
Documentation/devicetree/bindings/arm/arm,coresight-tmc.example.dts]
Error 1
make[2]: *** Waiting for unfinished jobs....
./Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml:104:4:
did not find expected key
/builds/robherring/dt-review-
ci/linux/Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml:
ignoring, error parsing file
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1500:
dt_binding_check] Error 2
make: *** [Makefile:234: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://urldefense.proofpoint.com/v2/url?u=https-
3A__patchwork.ozlabs.org_project_devicetree-
2Dbindings_patch_20230904050548.28047-2D2-2Dlcherian-
40marvell.com&d=DwIDaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=DI9kird_6lFtBC
VoGa5ogk3dJwsUlHLjLlgu0r46iU4&m=_ay-
WtrQlhIwxRafvVeVQHuS8jVWvIzZWMmn3Kp2yAVpxITz-
rjWiL4cMybMomHi&s=zvUJitULz2sVzal1I78gUQ3sBBTSAZmwDziKSNJbxwM&
e=

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above error(s),
then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your
schema.

Ack. Will fix this in next version.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel