Thread (22 messages) 22 messages, 4 authors, 2023-09-25

Re: [PATCH 5/6] arm64: dts: allwinner: h616: Add CPU Operating Performance Points table

From: Martin Botka <hidden>
Date: 2023-09-04 19:44:12
Also in: linux-devicetree, linux-pm, linux-sunxi, lkml


On Mon, Sep 4 2023 at 09:33:33 PM +02:00:00, Krzysztof Kozlowski 
[off-list ref] wrote:
On 04/09/2023 17:57, Martin Botka wrote:
quoted
 Add an Operating Performance Points table for the CPU cores to
 enable Dynamic Voltage & Frequency Scaling on the H616.
...
quoted
 diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi 
b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
 index 063db9634e5f..78e79c591dba 100644
 --- a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
 +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
 @@ -143,6 +143,10 @@ sid: efuse@3006000 {
  			ths_calibration: thermal-sensor-calibration@14 {
  				reg = <0x14 0x8>;
  			};
 +
 +			cpu_speed_grade: cpu_speed_grade@0 {
Underscores are no allowed in node names.

It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
I actually did. And did rerun it just now to check. No error or warning 
was reported by dtbs_check W=1 for this.
But I will correct it in V2 and look if my setup is doing something 
wrong that its not reporting these issues.
Cheers,
Martin
Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help