Re: [PATCH] PCI: mvebu: Mark driver as BROKEN
From: Uwe Kleine-König <hidden>
Date: 2023-08-04 17:01:19
Also in:
linux-pci
Hello, On Fri, Aug 04, 2023 at 03:46:22PM +0200, Uwe Kleine-König wrote:
On Fri, Aug 04, 2023 at 12:35:13PM +0100, Russell King (Oracle) wrote:quoted
So it seems this patch got applied, but it wasn't Cc'd to linux-arm-kernel or anyone else, so those of us with platforms never had a chance to comment on it. *** This change causes a regression to working setups. *** It appears that the *only* reason this patch was proposed is to stop a kernel developer receiving problem reports from a set of users, but completely ignores that there is another group of users where this works fine - and thus the addition of this patch causes working setups to regress. Because one is being bothered with problem reports is not a reason to mark a driver broken - and especially not doing so in a way that those who may be affected don't get an opportunity to comment on the patch! Also, there is _zero_ information provided on what the reported problems actually are, so no one else can guess what these issues are. However, given that there are working setups and this change causes those to regress, it needs to be reverted. For example, I have an Atheros PCIe WiFi card in an Armada 388 Clearfog platform, and this works fine. Uwe has a SATA controller for a bunch of disks in an Armada 370 based NAS platform that is connected to PCIe, and removing PCIe support effectively makes his platform utterly useless.While this is true there is really a problem on my platform with accessing the hard disks via that pci controller and a 88SE9215 SATA controller. While it seems to work in principle, it's incredible slow. I intend to bisect that, 6.1.x is still fine. Don't know when I find the time though, as there are a few things that are more important currently.
I did that and found next-20230803 to be bad but next-20230804 is good. I didn't debug that further and didn't spot anything obvious in git log --oneline --no-merges --left-right next-20230803...next-20230804 . I will just assume the problem is gone for good. So now I'm in the position to say: For me PCI_MVEBU works fine and so I support Russell's request to revert b3574f579ece24439c90e9a179742c61205fbcfa. Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |