Re: [PATCH net-next v5 5/9] netdev: expose DPLL pin handle for netdevice
From: Jakub Kicinski <kuba@kernel.org>
Date: 2023-08-23 02:11:58
Also in:
intel-wired-lan, linux-clk, netdev
On Wed, 23 Aug 2023 00:00:33 +0100 Vadim Fedorenko wrote:
quoted hunk ↗ jump to hunk
static int dpll_msg_add_mode(struct sk_buff *msg, struct dpll_device *dpll,@@ -340,6 +352,7 @@ dpll_cmd_pin_get_one(struct sk_buff *msg, struct dpll_pin *pin, ref = dpll_xa_ref_dpll_first(&pin->dpll_refs); ASSERT_NOT_NULL(ref); + ret = dpll_msg_add_pin_handle(msg, pin); if (ret) return ret;
Chunk out of place
quoted hunk ↗ jump to hunk
diff --git a/include/linux/dpll.h b/include/linux/dpll.h index 2202310c10cd..9b612038b538 100644 --- a/include/linux/dpll.h +++ b/include/linux/dpll.h@@ -101,6 +101,26 @@ struct dpll_pin_properties { struct dpll_pin_frequency *freq_supported; }; +#if IS_ENABLED(CONFIG_DPLL) + +size_t dpll_msg_pin_handle_size(struct dpll_pin *pin); + +int dpll_msg_add_pin_handle(struct sk_buff *msg, struct dpll_pin *pin); + +#else + +static inline size_t dpll_msg_pin_handle_size(struct dpll_pin *pin) +{ + return 0; +} + +static inline int dpll_msg_add_pin_handle(struct sk_buff *msg, struct dpll_pin *pin) +{ + return 0; +} + +#endif
The only empty line between #if and #endif that's needed is the one between the two static inline helpers
quoted hunk ↗ jump to hunk
struct dpll_device * dpll_device_get(u64 clock_id, u32 dev_driver_id, struct module *module);diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 0896aaa91dd7..36a872774173 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h@@ -34,6 +34,7 @@ #include <linux/rculist.h> #include <linux/workqueue.h> #include <linux/dynamic_queue_limits.h> +#include <linux/dpll.h>
Please no includes in netdevice.h, it's included in way too many places. All you need is a forward declaration of struct dpll_pin, AFAICT.
quoted hunk ↗ jump to hunk
diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h index ce3117df9cec..2e7df321f345 100644 --- a/include/uapi/linux/if_link.h +++ b/include/uapi/linux/if_link.h@@ -377,6 +377,8 @@ enum { IFLA_GSO_IPV4_MAX_SIZE, IFLA_GRO_IPV4_MAX_SIZE, + IFLA_DPLL_PIN, +
No empty lines, no idea who started this trend but let's stop it.
__IFLA_MAX };
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel