Thread (37 messages) 37 messages, 4 authors, 2023-08-22

Re: [PATCH net-next v4 7/9] ice: implement dpll interface to control cgu

From: Jiri Pirko <jiri@resnulli.us>
Date: 2023-08-12 06:19:51
Also in: intel-wired-lan, linux-clk, netdev

Fri, Aug 11, 2023 at 10:03:38PM CEST, vadim.fedorenko@linux.dev wrote:

[...]

quoted hunk ↗ jump to hunk
@@ -4690,6 +4694,8 @@ static void ice_deinit_features(struct ice_pf *pf)
		ice_gnss_exit(pf);
	if (test_bit(ICE_FLAG_PTP_SUPPORTED, pf->flags))
		ice_ptp_release(pf);
+	if (test_bit(ICE_FLAG_DPLL, pf->flags))
This is a duplicate test as you test it as a first thing in
ice_dpll_deinit(). But nevermind this nit, let's have v4 merged
if possible.

+		ice_dpll_deinit(pf);
}

static void ice_init_wakeup(struct ice_pf *pf)
-- 
2.27.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help