Thread (5 messages) 5 messages, 2 authors, 2023-08-31

Re: [PATCH v1] firmware: arm_scmi: Fix NULL pointer dereference in mailbox_clear_channel

From: Sudeep Holla <hidden>
Date: 2023-08-30 19:23:14
Also in: lkml

On Wed, Aug 30, 2023 at 01:07:47AM +0800, Qiujun Huang wrote:
There is a race between the failure of probe and rx_callback (due to a
delayed response).

scmi_probe
scmi_acquire_protocal
do_xfer
 timeout
mailbox_chan_free
                                                    <--- delay response
                                                           rx_callback
mbox_free_channel
cinfo->transport_info = NULL
                                                          mailbox_clear_channel
                                                         dereference cinfo->transport_info
It is always good to provide the kernel stacktrace which you get when a
NULL pointer is dereference. It helps for review and also to document it.

-- 
Regards,
Sudeep

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help