Re: [PATCH v2] Minerva: Add Meta openBMC Minerva dts file.
flat view
From: Krzysztof Kozlowski <hidden>
Date: 2023-08-28 07:01:42
Also in:
linux-aspeed, linux-devicetree, lkml
On 28/08/2023 05:17, peteryin wrote:
This is for Meta openBMC Minerva dts. Kernel:dev-6.1
??? NAK. We do not develop there. Also subject is totally wrong. Drop redundant pieces, drop full stop. Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching.
Signed-off-by: peteryin <redacted> --- v1 link : https://lore.kernel.org/all/fb09f5e6-8381-312f-2f1e-f2b471cec68a@linaro.org/ (local) Change log: v1: 1. Create minerva dts file. v2: 1.Add facebook,minerva-bmc in aspeed.yaml 2.use stdout-path 3.Add Makefile --- .../bindings/arm/aspeed/aspeed.yaml | 1 +
Please run scripts/checkpatch.pl and fix reported warnings. Some warnings can be ignored, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear.
quoted hunk ↗ jump to hunk
arch/arm/boot/dts/Makefile | 1 + .../boot/dts/aspeed-bmc-facebook-minerva.dts | 329 ++++++++++++++++++ 3 files changed, 331 insertions(+) create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-minerva.dtsdiff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml index fb4ce5df2fa0..9d1b26e7ca6b 100644 --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml@@ -79,6 +79,7 @@ properties: - facebook,elbert-bmc - facebook,fuji-bmc - facebook,greatlakes-bmc + - facebook,minerva-bmc - ibm,everest-bmc - ibm,rainier-bmc - ibm,tacoma-bmcdiff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index 6a897ff40ff0..e7c00905a08b 100644 --- a/arch/arm/boot/dts/Makefile +++ b/arch/arm/boot/dts/Makefile@@ -1603,6 +1603,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ aspeed-bmc-facebook-wedge400.dtb \ aspeed-bmc-facebook-yamp.dtb \ aspeed-bmc-facebook-yosemitev2.dtb \ + aspeed-bmc-facebook-minerva.dtb \
Wrong order. 'm' is not after 'y'. ...
quoted hunk ↗ jump to hunk
+ /*X0-X7*/ "","","","","","","","", + /*Y0-Y7*/ "","","","","","","","", + /*Z0-Z7*/ "","","","","","","",""; +}; +
Still redundant blank line. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel