Re: [PATCH v7 1/2] dt-bindings: hwmon: Support Aspeed g6 PWM TACH Control
From: Rob Herring <robh@kernel.org>
Date: 2023-08-23 13:13:42
Also in:
linux-aspeed, linux-devicetree, linux-doc, linux-hwmon, linux-pwm, lkml
On Thu, Aug 17, 2023 at 08:00:28PM +0800, Billy Tsai wrote:
quoted hunk ↗ jump to hunk
Document the compatible for aspeed,ast2600-pwm-tach device, which can support upto 16 PWM outputs and 16 fan tach input. Signed-off-by: Billy Tsai <redacted> --- .../bindings/hwmon/aspeed,g6-pwm-tach.yaml | 57 +++++++++++++++++++ 1 file changed, 57 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwmon/aspeed,g6-pwm-tach.yamldiff --git a/Documentation/devicetree/bindings/hwmon/aspeed,g6-pwm-tach.yaml b/Documentation/devicetree/bindings/hwmon/aspeed,g6-pwm-tach.yaml new file mode 100644 index 000000000000..1666304d0b0f --- /dev/null +++ b/Documentation/devicetree/bindings/hwmon/aspeed,g6-pwm-tach.yaml@@ -0,0 +1,57 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (C) 2021 Aspeed, Inc. +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/hwmon/aspeed,g6-pwm-tach.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: ASPEED G6 PWM and Fan Tach controller device driver + +maintainers: + - Billy Tsai <billy_tsai@aspeedtech.com> + +description: | + The ASPEED PWM controller can support upto 16 PWM outputs. + The ASPEED Fan Tacho controller can support upto 16 fan tach input. + +properties: + compatible: + enum: + - aspeed,ast2600-pwm-tach + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + resets: + maxItems: 1 + + "#pwm-cells": + const: 3 + + aspeed,fan-tach-ch: + description: Specify the Fan tach input channels. + $ref: "/schemas/types.yaml#/definitions/uint8-array"
This property is already defined in aspeed-pwm-tacho.txt as a single u8 that goes in a fan node. You can't redefine its type and location here. To repeat what I've said in previous versions, work with others to define a common fan and fan controller binding. Otherwise, anything new with fan related properties is simply going to be rejected. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel