Re: [PATCH 1/2] TSD: arm64: dts: rockchip: use codec as clock master
flat view
From: Heiko Stübner <heiko@sntech.de>
Date: 2023-08-23 12:39:16
Also in:
linux-devicetree, linux-rockchip, lkml
Hi Jakob, the change itself looks ok, but there are some logistic changes needed. For one, please drop the local TSD prefix from patches submitted upstream. The patch subject should be something like arm64: dts: rockchip: use codec as clock master on px30-ringneck Am Mittwoch, 23. August 2023, 14:19:59 CEST schrieb Jakob Unterwurzacher:
From: Ermin Sunj <redacted> If the codec is not the clock master, the MCLK needs to be synchronous to both I2S_SCL ans I2S_LRCLK. We do not have that on Haikou, causing distorted audio. Before: Running audioloopback.py script on Ringneck, 1kHz output sine wave is not stable and shows distortion. After: 10h stress tests audioloopback.py failed only one time. That is 0.00014% failure rate. Signed-off-by: Ermin Sunj <redacted>
As sender of the patch you need to add another Signed-off-by line of your own. With this you indicate that you were allowed to submit the patch. So this needs two SOB-lines, one for Ermin as the original author and one for you as the submitter. Probably same for the second patch. Thanks Heiko
quoted hunk ↗ jump to hunk
--- arch/arm64/boot/dts/rockchip/px30-ringneck-haikou.dts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)diff --git a/arch/arm64/boot/dts/rockchip/px30-ringneck-haikou.dts b/arch/arm64/boot/dts/rockchip/px30-ringneck-haikou.dts index 3a447d03e2a8..dafeef0c2dab 100644 --- a/arch/arm64/boot/dts/rockchip/px30-ringneck-haikou.dts +++ b/arch/arm64/boot/dts/rockchip/px30-ringneck-haikou.dts@@ -68,8 +68,10 @@ i2s0-sound { simple-audio-card,format = "i2s"; simple-audio-card,name = "Haikou,I2S-codec"; simple-audio-card,mclk-fs = <512>; + simple-audio-card,frame-master = <&sgtl5000_codec>; + simple-audio-card,bitclock-master = <&sgtl5000_codec>; - simple-audio-card,codec { + sgtl5000_codec: simple-audio-card,codec { clocks = <&sgtl5000_clk>; sound-dai = <&sgtl5000>; };
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel