Re: [PATCH] dt-bindings: pinctrl: aspeed: Allow only defined pin mux node properties
From: Linus Walleij <hidden>
Date: 2023-08-21 10:33:08
Also in:
linux-aspeed, linux-devicetree, linux-gpio, lkml, openbmc
On Sat, Aug 19, 2023 at 3:09 AM Rob Herring [off-list ref] wrote:
The Aspeed pinctrl bindings are missing an additionalProperties/ unevaluatedProperties schemas on the child pin mux nodes which means any undefined properties are allowed. In addition, using 'additionalProperties' for child nodes with any name works better than a pattern matching everything with an if/then schema to select nodes only. With 'additionalProperties' added, 'pins' and 'bias-disable' properties need to be added as they were not defined. A $ref to pinmux-node.yaml which defines the common property types was also missing. Signed-off-by: Rob Herring <robh@kernel.org>
Patch applied!
Really 'pins' should have some constraints, but I don't know what the possible values are. Happy to add if someone can tell me what.
Aspeed folks: put this on your TODO! Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel