Re: [PATCH v2 0/5] drm/rockchip: Fix crtc duplicate state and crtc reset funcs
From: Heiko Stübner <heiko@sntech.de>
Date: 2023-08-12 22:34:49
Also in:
dri-devel, linux-rockchip, lkml
Hi Jonas, Am Samstag, 12. August 2023, 16:18:05 CEST schrieb Jonas Karlman:
Please consider reviewing and merging this series [2], and also [3].
during the last months my testfarm aquired some issues, I'm still working on fixing, so my testing is way limited right now.
drm/rockchip: Fix crtc duplicate state and crtc reset funcs [2] https://lore.kernel.org/all/20230621223311.2239547-1-jonas@kwiboo.se/ (local)
Though this one looked easy and when going through the code looked quite right.
drm/rockchip: vop: Add NV15, NV20 and NV30 support [3] https://lore.kernel.org/all/20230618220122.3911297-1-jonas@kwiboo.se/ (local)
I guess I need to track down someone on IRC to tell me if these new NVxx types look correct, because I don't have too much clue about those drm-formats yet. Hopefully I'll get to that on monday. Heiko
On 2023-06-22 00:33, Jonas Karlman wrote:quoted
This series fixes a reset of state in duplicate state crtc funcs for VOP driver, a possible crash and ensure crtc reset helper is called in VOP2 driver. Patch 1 use kmemdup instead of kzalloc to duplicate the crtc state. Patch 2 change to use crtc and plane cleanup helpers directly. Patch 3 adds a null guard for allocation failure. Patch 4 adds a crash guard for empty crtc state. Patch 5 adds a missing call to crtc reset helper. This is the next part of an ongoing effort to upstream HDMI 2.0 support used in LibreELEC for the past 3+ years. Changes in v2: - Handle possible allocation failure in crtc reset funcs - Collect r-b tags This series is also available at [1]. [1] https://github.com/Kwiboo/linux-rockchip/commits/next-20230621-duplicate-state Jonas Karlman (5): drm/rockchip: vop: Fix reset of state in duplicate state crtc funcs drm/rockchip: vop: Use cleanup helper directly as destroy funcs drm/rockchip: vop: Fix call to crtc reset helper drm/rockchip: vop2: Don't crash for invalid duplicate_state drm/rockchip: vop2: Add missing call to crtc reset helper drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 24 +++++------- drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 39 ++++++++++---------- 2 files changed, 28 insertions(+), 35 deletions(-)
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel