Re: [PATCH 3/4] dt-bindings: net: dsa: realtek: require compatible property under mdio node
From: Arınç ÜNAL <hidden>
Date: 2023-08-12 16:32:12
Also in:
linux-devicetree, linux-mediatek, lkml, netdev
I will drop this patch because only the SMI controlled switches must define the compatible string. There's no way to make a distinction between the SMI and MDIO controlled switches on the schema so this would mean requiring the compatible property for the MDIO controlled switches too which is wrong. Arınç On 12.08.2023 12:17, Arınç ÜNAL wrote:
quoted hunk ↗ jump to hunk
The compatible property must be defined under the mdio node. Enforce it. Signed-off-by: Arınç ÜNAL <redacted> --- Documentation/devicetree/bindings/net/dsa/realtek.yaml | 3 +++ 1 file changed, 3 insertions(+)diff --git a/Documentation/devicetree/bindings/net/dsa/realtek.yaml b/Documentation/devicetree/bindings/net/dsa/realtek.yaml index ea7db0890abc..f600e65fc990 100644 --- a/Documentation/devicetree/bindings/net/dsa/realtek.yaml +++ b/Documentation/devicetree/bindings/net/dsa/realtek.yaml@@ -103,6 +103,9 @@ allOf: compatible: const: realtek,smi-mdio + required: + - compatible + - if: required: - reg
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel