Thread (2 messages) read the whole thread 2 messages, 2 authors, 2023-08-05

Re: [PATCH -next] i2c: s3c2410: Remove unused extern declarations

From: Andi Shyti <andi.shyti@kernel.org>
Date: 2023-08-05 22:14:02
Also in: linux-samsung-soc, lkml

Hi Yue,

On Fri, Jul 28, 2023 at 09:23:18PM +0800, Yue Haibing wrote:
commit 0d297df03890 ("ARM: s3c: simplify platform code") left behind
s3c_i2c(*)_set_platdata().
commit d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code")
leave s5p_i2c_hdmiphy_set_platdata() declaration.
And commit bad1e6aadd17 ("ARM: SAMSUNG: Cleanup plat-samsung/devs.c and devs.h")
leave s3c_i2c(*)_cfg_gpio() alone.
I don't understand anything from the commit message here.

How about:

"
After some cleanups[*] certain s3c_i2c(*)_cfg_gpio() prototypes
have become unused. Remove them.

[*] 0d297df03890 ("ARM: s3c: simplify platform code")
    d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code")
    bad1e6aadd17 ("ARM: SAMSUNG: Cleanup plat-samsung/devs.c and devs.h")
"
Signed-off-by: Yue Haibing <redacted>
Reviewed-by: Andi Shyti <andi.shyti@kernel.org> 

which branch should this go? Samsung or i2c?

Andi

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help