Re: [PATCH] i2c: aspeed: Avoid accessing freed buffers during i2c transfers.
From: Andi Shyti <andi.shyti@kernel.org>
Date: 2023-08-05 10:10:13
Also in:
linux-aspeed, linux-i2c, lkml, openbmc
Hi Lixue, On Fri, Jul 28, 2023 at 12:24:16PM +0000, Lixue Liang wrote:
From: Lixue Liang <redacted> After waiting for the transmission timeout, the I2C controller will continue to transmit data when the bus is idle. Clearing bus->msg will avoid kernel panic when accessing the freed msg->buf in aspeed_i2c_master_irq.
actually in aspeed_i2c_master_irq() you are already checking for !bus->msgs. What kind of panic are you referring to? Andi
quoted hunk
Signed-off-by: Lixue Liang <redacted> --- drivers/i2c/busses/i2c-aspeed.c | 2 ++ 1 file changed, 2 insertions(+)diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c index 2e5acfeb76c8..c83057497e26 100644 --- a/drivers/i2c/busses/i2c-aspeed.c +++ b/drivers/i2c/busses/i2c-aspeed.c@@ -713,6 +713,8 @@ static int aspeed_i2c_master_xfer(struct i2c_adapter *adap, spin_lock_irqsave(&bus->lock, flags); if (bus->master_state == ASPEED_I2C_MASTER_PENDING) bus->master_state = ASPEED_I2C_MASTER_INACTIVE; + + bus->msgs = NULL; spin_unlock_irqrestore(&bus->lock, flags); return -ETIMEDOUT;-- 2.27.0
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel