Re: [PATCH] wifi: mt76: Replace strlcpy with strscpy
From: Kalle Valo <kvalo@kernel.org>
Date: 2023-08-01 09:12:29
Also in:
linux-hardening, linux-mediatek, linux-wireless, lkml
Kees Cook [off-list ref] writes:
On Thu, Jul 27, 2023 at 07:00:21PM +0300, Kalle Valo wrote:quoted
Kees Cook [off-list ref] writes:quoted
On Mon, 03 Jul 2023 18:12:56 +0000, Azeem Shaikh wrote:quoted
strlcpy() reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to remove strlcpy() completely [2], replace strlcpy() here with strscpy(). [...]Applied, thanks! [1/1] wifi: mt76: Replace strlcpy with strscpy https://git.kernel.org/kees/c/535c78cbc0c4Why did you take this? mt76 is in active development so risk of conflicts is high.There didn't seem to be any further activity for 3 weeks, and it was a relatively mechanical change.
That's because the wireless trees were on a summer break: https://lore.kernel.org/all/87y1kncuh4.fsf@kernel.org/ (local)
I can drop it from my tree.
Yes, please drop this. And in the future don't take any wireless patches unless acked by Johannes or me, I want to minimize the risk of conflicts between the trees. If a patch is missed for whatever reason please let me know, do not take it to your tree.
What's needed for it to be picked up through wireless?
I don't know why Felix didn't take this patch but now I assigned it to me on patchwork: https://patchwork.kernel.org/project/linux-wireless/patch/20230703181256.3712079-1-azeemshaikh38@gmail.com/ It should be in wireless-next this week. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel