On 31/07/2023 09:31, Maso Huang (黃加竹) wrote:

On Fri, 2023-07-28 at 14:49 +0200, Krzysztof Kozlowski wrote:

quoted

 	 
External email : Please do not click links or open attachments until
you have verified the sender or the content.
 On 28/07/2023 11:08, Maso Huang wrote:

quoted

Add document for mt7986 board with wm8960.

Signed-off-by: Maso Huang <redacted>
---
 .../sound/mediatek,mt7986-wm8960.yaml         | 53

+++++++++++++++++++

quoted

 1 file changed, 53 insertions(+)
 create mode 100644

Documentation/devicetree/bindings/sound/mediatek,mt7986-wm8960.yaml

quoted

diff --git

a/Documentation/devicetree/bindings/sound/mediatek,mt7986-wm8960.yaml 
b/Documentation/devicetree/bindings/sound/mediatek,mt7986-wm8960.yaml

quoted

new file mode 100644
index 000000000000..76394f7e5502

--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/mediatek,mt7986-

wm8960.yaml

quoted

@@ -0,0 +1,53 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: 

http://devicetree.org/schemas/sound/mediatek,mt7986-wm8960.yaml#

quoted

+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MediaTek MT7986 sound card with WM8960 codec
+
+maintainers:
+  - Maso Huang [off-list ref]
+
+properties:
+  compatible:
+    const: mediatek,mt7986-wm8960-machine
+
+  mediatek,platform:
+    $ref: /schemas/types.yaml#/definitions/phandle
+    description: The phandle of MT7986 platform.
+
+  audio-routing:
+    $ref: /schemas/types.yaml#/definitions/non-unique-string-array
+    description:
+      A list of the connections between audio components. Each

entry is a

quoted

+      sink/source pair of strings. Valid names could be the input

or output

quoted

+      widgets of audio components, power supplies, MicBias of

codec and the

quoted

+      software switch.
+
+  mediatek,audio-codec:
+    $ref: /schemas/types.yaml#/definitions/phandle
+    description: The phandle of wm8960 codec.
+

How did you implement Rob's comment? Or did you just ignore it?

Best regards,
Krzysztof

Hi Krzysztof,

Sorry, I did not mean to ignore Rob's comment.
I waited for some suggestion in mail below, but it seems Rob was a
little busy.

https://lore.kernel.org/lkml/8c6316e79e40406e4d46709f602dcb14a4c00562.camel@mediatek.com/ (local)

After gentle ping last week and receiving your advice, I thought that
means to send the v3 patch and might discuss dtbingding in v3 series.

So sorry for misunderstanding it, I'll check the details with Rob in v3
series then refine it in v4.

The problem is that you did not reference in this patch any ongoing
discussion and further questions, so comment looks like addressed, while
it was not.

Rob said:
"in a common schema and reference them "
You said:
"common part yaml and reference to it"
so I think you both agreed on the same.

The advice would be to create common binding which is then referenced by
other and your bindings. However if you start doing it, you will notice
that it is impossible, because you have conflicting types for
"audio-codec", so you cannot have one definition.

This leads to the point - property is probably wrong and you need
dai-link with sound-dai property, just like most cards are doing.

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel