Thread (23 messages) 23 messages, 5 authors, 2023-08-01

Re: [PATCH v4 10/10] perf: tests: Adapt mmap-basic.c for riscv

From: Ian Rogers <irogers@google.com>
Date: 2023-07-28 17:54:35
Also in: linux-doc, linux-perf-users, linux-riscv, lkml

On Thu, Jul 27, 2023 at 7:30 AM Alexandre Ghiti [off-list ref] wrote:
quoted hunk ↗ jump to hunk
riscv now supports mmaping hardware counters to userspace so adapt the test
to run on this architecture.

Signed-off-by: Alexandre Ghiti <redacted>
Reviewed-by: Andrew Jones <redacted>
Reviewed-by: Atish Patra <redacted>
---
 tools/perf/tests/mmap-basic.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/tests/mmap-basic.c b/tools/perf/tests/mmap-basic.c
index e68ca6229756..f5075ca774f8 100644
--- a/tools/perf/tests/mmap-basic.c
+++ b/tools/perf/tests/mmap-basic.c
@@ -284,7 +284,7 @@ static struct test_case tests__basic_mmap[] = {
                         "permissions"),
        TEST_CASE_REASON("User space counter reading of instructions",
                         mmap_user_read_instr,
-#if defined(__i386__) || defined(__x86_64__) || defined(__aarch64__)
+#if defined(__i386__) || defined(__x86_64__) || defined(__aarch64__) || __riscv_xlen == 64
Same comment relating to the guard, why not defined(__riscv) ?

Thanks,
Ian
quoted hunk ↗ jump to hunk
                         "permissions"
 #else
                         "unsupported"
@@ -292,7 +292,7 @@ static struct test_case tests__basic_mmap[] = {
                ),
        TEST_CASE_REASON("User space counter reading of cycles",
                         mmap_user_read_cycles,
-#if defined(__i386__) || defined(__x86_64__) || defined(__aarch64__)
+#if defined(__i386__) || defined(__x86_64__) || defined(__aarch64__) || __riscv_xlen == 64
                         "permissions"
 #else
                         "unsupported"
--
2.39.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help