Thread (13 messages) 13 messages, 6 authors, 2023-07-28

Re: [PATCH v3] ACPI/IORT: Remove erroneous id_count check in iort_node_get_rmr_info()

From: Lorenzo Pieralisi <lpieralisi@kernel.org>
Date: 2023-07-27 14:18:00
Also in: linux-acpi, lkml

On Thu, Jul 27, 2023 at 02:59:02PM +0100, Catalin Marinas wrote:
On Thu, Jul 27, 2023 at 03:39:27PM +0200, Lorenzo Pieralisi wrote:
quoted
On Mon, Jul 17, 2023 at 07:33:45PM +0800, Guanghui Feng wrote:
quoted
According to the ARM IORT specifications DEN 0049 issue E,
the "Number of IDs" field in the ID mapping format reports
the number of IDs in the mapping range minus one.

In iort_node_get_rmr_info(), we erroneously skip ID mappings
whose "Number of IDs" equal to 0, resulting in valid mapping
nodes with a single ID to map being skipped, which is wrong.

Fix iort_node_get_rmr_info() by removing the bogus id_count
check.

Fixes: 491cf4a6735a ("ACPI/IORT: Add support to retrieve IORT RMR reserved regions")
Signed-off-by: Guanghui Feng <redacted>
---
 drivers/acpi/arm64/iort.c | 3 ---
 1 file changed, 3 deletions(-)
Acked-by: Lorenzo Pieralisi <lpieralisi@kernel.org>

Catalin/Will,

can you pick this up please ?
Would you like it merged in 6.5 or 6.6 is fine?
It is definitely a fix - I don't think that's super urgent
though, bug has been there since v6.0 so the fix can probably
wait to trickle back from v6.6.

Thanks,
Lorenzo
Thanks.

-- 
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help