On Sat, Jul 15, 2023 at 12:34 PM Thomas Zimmermann [off-list ref] wrote:

Hi

Am 14.07.23 um 19:50 schrieb Rob Herring:

quoted

The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it as merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h. As a result, there's a pretty much random mix of those include
files used throughout the tree. In order to detangle these headers and
replace the implicit includes with struct declarations, users need to
explicitly include the correct includes.

Signed-off-by: Rob Herring <robh@kernel.org>

[...]

quoted

@@ -48,7 +48,7 @@ int sbusfb_mmap_helper(struct sbus_mmap_map *map,
      unsigned long map_offset = 0;
      unsigned long off;
      int i;
-
+

The various whitespace fixes should rather go into a separate patch. You
can add

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

to the whitespace fix and the include cleanup.

Indeed. I missed dropping the whitespace change.

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel