Re: [PATCH v4 5/9] virt: geniezone: Add irqfd support

On Tue, Jun 27, 2023, at 09:54, Yi-De Wu (吳一德) wrote:

quoted

..snip.. 

quoted

diff --git a/drivers/virt/geniezone/gzvm_main.c b/drivers/virt/geniezone/gzvm_main.c > index 230970cb0953..e62c046d76b3 100644 > --- a/drivers/virt/geniezone/gzvm_main.c > +++ b/drivers/virt/geniezone/gzvm_main.c > @@ -113,11 +113,12 @@ static int gzvm_drv_probe(void) >   return ret; >   gzvm_debug_dev = &gzvm_dev; >   > -return 0; > +return gzvm_drv_irqfd_init(); 

ret = gzvm_drv_irqfd_init(); if (ret) return ret; 

Something went wrong with the quoting up here, please make sure to
use plaintext email instead of html.

quoted

return 0; 

We're wondering the pros and cons for this coding style.
Could you kindly give us some hint for possibly we could miss it somewhere.

Some other suggestion had been made by AOSP reviewer on the very line 
mentioned. As a consequence, we'd like to dig in the rationale behind 
such debate.
https://android-review.googlesource.com/c/kernel/common/+/2574178/comment/f23bbd52_e3b14396/

I think most developers prefer the shorter form here, and I've
seen cleanup patches actually changing the longer version to that.

     Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel