Re: [PATCH V2 3/3] dt-bindings: serial: fsl-lpuart: add imx8ulp compatible string
From: Krzysztof Kozlowski <hidden>
Date: 2023-06-26 15:46:59
Also in:
linux-devicetree, linux-serial, lkml
On 26/06/2023 06:48, Sherry Sun wrote:
quoted hunk ↗ jump to hunk
Add imx8ulp compatible string in lpuart dt-binding, also correct the imx93 compatible here, imx93/imx8ulp add some new features based on imx7ulp lpuart, so need to add "fsl,imx8ulp-lpuart" for imx93 to enable those new features. Signed-off-by: Sherry Sun <redacted> --- Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml index 93062403276b..272bfbb1cdfc 100644 --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml@@ -21,12 +21,15 @@ properties: - fsl,ls1021a-lpuart - fsl,ls1028a-lpuart - fsl,imx7ulp-lpuart + - fsl,imx8ulp-lpuart
I don't understand this. Commit msg also does not explain this.
- fsl,imx8qxp-lpuart
- fsl,imxrt1050-lpuart
- items:
- - enum:
- - fsl,imx93-lpuart
- - fsl,imx8ulp-lpuartThis could have stayed as enum with one entry which would make your diff more readable.
+ - const: fsl,imx8ulp-lpuart + - const: fsl,imx7ulp-lpuart
Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel