Re: [PATCH] usb: gadget: aspeed: fix buffer overflow

On Wed, Jun 21, 2023 at 08:02:14PM +0800, Lei Yu wrote:

On Wed, Dec 21, 2022 at 10:26 AM Lei Yu [off-list ref] wrote:

quoted

On Wed, Dec 21, 2022 at 10:17 AM Neal Liu [off-list ref] wrote:

quoted

quoted

quoted

quoted

quoted

quoted

Using rndis is able to set MTU to 2000, and the issue can be

reproduced.

USB ecm is also tested and it is possible to set MTU to 2000, and could
reproduce the issue.
So I think this patch is needed anyway.

@Neal Liu Could you kindly help to verify the USB ECM case?

How to set MTU to 2000 on USB ECM case? I remember last time I cannot set by using "ifconfig ..."
Regardless ECM or RNDIS, I agree this patch is still needed.

You were able to set MTU to 2000 for RNDIS but not for NCM.
@Greg Kroah-Hartman indicated that RNDIS should not be used anymore.
So I tested ECM and verified it could set MTU 2000 and the issue could
be reproduced.

This patch fixes the kernel oops in the aspeed-vhub driver for both
USB ECM and RNDIS.
It now has an Acked-by from benh and Reviewed-by from neal_liu

Should we merge this patch?

Can you please resend it?

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel