Re: [patch 12/17] init: Invoke arch_cpu_finalize_init() earlier

From
Thomas Gleixner <hidden>
Date
2023-06-15 22:03:52
Also in
linux-m68k, linux-mips, linux-sh, linux-um, lkml, loongarch, sparclinux
Reply to
Edgecombe, Rick P, 2023-06-15
On Thu, Jun 15 2023 at 21:44, Rick P. Edgecombe wrote:
On Wed, 2023-06-14 at 01:39 +0200, Thomas Gleixner wrote:
quoted
Fortunately none of the init calls between calibrate_delay() and
arch_cpu_finalize_init() is relevant for the functionality of
arch_cpu_finalize_init().
Reviewed-by: Rick Edgecombe <rick.p.edgecombe@intel.com>

I did my best to find a counterpoint to this statement. The only thing
I found was that lockdep_init_task(&init_task) in fork_init() is now
called after the spin_lock() usage in set_memory_4k().

But AFAICT, that whole lockdep_init_task() call is unneeded because
the fields it sets are already statically initialized.
Correct. The call there looks absolute pointless. Peter?

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Thread (45 messages) 45 messages, 14 authors, last reply 2023-09-01
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help