Re: [PATCH v4 16/21] PM / devfreq: rockchip-dfi: make register stride SoC specific
From: Sascha Hauer <s.hauer@pengutronix.de>
Date: 2023-05-19 06:45:46
Also in:
linux-rockchip
On Tue, May 16, 2023 at 05:18:27PM +0100, Jonathan Cameron wrote:
On Fri, 5 May 2023 13:38:51 +0200 Sascha Hauer [off-list ref] wrote:quoted
The currently supported RK3399 has a stride of 20 between the channel specific registers. Upcoming RK3588 has a different stride, so put the stride into driver data to make it configurable. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>LGTM though the flip from decimal to hex is a little odd. Which makes sense probably depends on what the datasheet uses...
The datasheet only describes the actual register offsets, no distance between them. However, the rk3588 has a stride of 0x4000 which definitely reads better in hex. For consistency I changed to hex here as well. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel