Re: [PATCH 1/2] dt-bindings: thermal: mediatek: Move auxdac binding to yaml

On 31/05/2023 00:02, Conor Dooley wrote:

Hey Matthias,

On Tue, May 30, 2023 at 05:04:12PM +0200, matthias.bgg@kernel.org wrote:

quoted

+  The MediaTek thermal controller measures the on-SoC temperatures.
+  This device does not have its own ADC, instead it directly controls
+  the AUXADC via AHB bus accesses. For this reason this device needs
+  phandles to the AUXADC. Also it controls a mux in the apmixedsys
+  register space via AHB bus accesses, so a phandle to the APMIXEDSYS
+  is also needed.

That double "also" bothers my OCD greatly, but it is a faithful
conversion.

quoted

+  "#thermal-sensor-cells":
+    const: 1

quoted

-- #thermal-sensor-cells : Should be 0. See Documentation/devicetree/bindings/thermal/thermal-sensor.yaml for a description.

How come this has changed? I didn't see an explanation for it in either
of the patches.

Yep. Please mention the deviations from pure conversion and if not
obvious - justify them.

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel