On 29/05/2023 09:43, carlos.song@nxp.com wrote:
From: Clark Wang <xiaoning.wang@nxp.com>
Add i2c bus recovery configuration example.
Why? That's just example... also with coding style issue.
quoted hunk ↗ jump to hunk
Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>
Signed-off-by: Carlos Song <redacted>
---
.../devicetree/bindings/i2c/i2c-imx-lpi2c.yaml | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml b/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml
index 4656f5112b84..62ee457496e4 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml
+++ b/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml
@@ -58,6 +58,16 @@ properties:
power-domains:
maxItems: 1
+ pinctrl-names:
+ minItems: 1
+ maxItems: 3
What's the benefit of this? Entries should be defined but without it is
not really helpful. Anyway not explained in commit msg.
quoted hunk ↗ jump to hunk
+
+ scl-gpios:
+ maxItems: 1
+
+ sda-gpios:
+ maxItems: 1
You don't need these two. Anyway not explained in commit msg.
quoted hunk ↗ jump to hunk
+
required:
- compatible
- reg
@@ -70,6 +80,7 @@ examples:
- |
#include <dt-bindings/clock/imx7ulp-clock.h>
#include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/gpio/gpio.h>
i2c@40a50000 {
compatible = "fsl,imx7ulp-lpi2c";@@ -78,4 +89,9 @@ examples:
interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clks IMX7ULP_CLK_LPI2C7>,
<&clks IMX7ULP_CLK_NIC1_BUS_DIV>;
+ pinctrl-names = "default","gpio";
Missing space.
quoted hunk ↗ jump to hunk
+ pinctrl-0 = <&pinctrl_i2c>;
+ pinctrl-1 = <&pinctrl_i2c_recovery>;
+ scl-gpios = <&gpio5 14 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
+ sda-gpios = <&gpio5 15 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
};
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel