Thread (24 messages) 24 messages, 5 authors, 2023-06-02

Re: [PATCH 02/11] pinctrl: stm32: add stm32mp257 pinctrl support

From: Alexandre TORGUE <alexandre.torgue@foss.st.com>
Date: 2023-05-30 08:39:01
Also in: linux-devicetree, linux-gpio, lkml

Hi Conor

On 5/29/23 20:04, Conor Dooley wrote:
On Mon, May 29, 2023 at 06:20:25PM +0200, Alexandre Torgue wrote:
quoted
Add stm32mp257 pinctrl support.
diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.h b/drivers/pinctrl/stm32/pinctrl-stm32.h
index e0c31c4c8bca..5e5de92ddd58 100644
--- a/drivers/pinctrl/stm32/pinctrl-stm32.h
+++ b/drivers/pinctrl/stm32/pinctrl-stm32.h
@@ -24,6 +24,9 @@
  #define STM32MP_PKG_AB		BIT(1)
  #define STM32MP_PKG_AC		BIT(2)
  #define STM32MP_PKG_AD		BIT(3)
+#define STM32MP_PKG_AI		BIT(8)
+#define STM32MP_PKG_AK		BIT(10)
+#define STM32MP_PKG_AL		BIT(11)
Mainly out of curiosity, why have you go duplicate defines for these?
Mainly to fit with available packages for various STM32 MPU. Currently 
MP1 SoCs are available with packages AB/AC/AD and MP2 series with 
AI/AK/AL but in the future we could have package AB/AC/AD/AI available 
for a particular SoC and then I need to anticipate this case.

Cheers
Alex
Cheers,
Conor.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help