Re: [PATCH v2 2/2] i2c: davinci: Use struct name not type with devm_kzalloc()

From
Bartosz Golaszewski <hidden>
Date
2023-05-16 14:45:46
Also in
linux-i2c, lkml
Reply to
Andrew Davis, 2023-05-15
On Mon, May 15, 2023 at 7:50 PM Andrew Davis [off-list ref] wrote:
quoted hunk ↗ jump to hunk
This reduces chance of error if the type of "dev" changes. While here
remove extra error print out, this is not usually done for memory
allocation failures.

Signed-off-by: Andrew Davis <redacted>
---
 drivers/i2c/busses/i2c-davinci.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c
index c55bd937def7..135f76593e6f 100644
--- a/drivers/i2c/busses/i2c-davinci.c
+++ b/drivers/i2c/busses/i2c-davinci.c
@@ -767,12 +767,9 @@ static int davinci_i2c_probe(struct platform_device *pdev)
        if (irq < 0)
                return dev_err_probe(&pdev->dev, irq, "can't get irq resource\n");

-       dev = devm_kzalloc(&pdev->dev, sizeof(struct davinci_i2c_dev),
-                       GFP_KERNEL);
-       if (!dev) {
-               dev_err(&pdev->dev, "Memory allocation failed\n");
+       dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL);
+       if (!dev)
                return -ENOMEM;
-       }

        init_completion(&dev->cmd_complete);

--
2.39.2
Reviewed-by: Bartosz Golaszewski <redacted>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Thread (12 messages) 12 messages, 4 authors, last reply 2023-06-23
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help