Thread (1 message) 1 message, 1 author, 2023-05-16

Re: [PATCH 02/23] arm64: zynqmp: Fix usb node drive strength and slew rate

From: Michal Simek <michal.simek@amd.com>
Date: 2023-05-16 13:30:58
Also in: linux-devicetree, lkml

Hi Laurent

On 5/10/23 08:54, Laurent Pinchart wrote:
Hi Michal,

Thank you for the patch.

On Tue, May 02, 2023 at 03:35:30PM +0200, Michal Simek wrote:
quoted
From: Ashok Reddy Soma <redacted>

As per design, all input/rx pins should have fast slew rate and 12mA
drive strength.
Why does the slow rate and drive strength matter for input pins ?
In design tools all inputs pins are setup like described by default.
That's why it could suggest that there is no need to describe default configuration in DT.
But all MIOs can be used as GPIOs where pinctrl can change their default values to something else. That's why setting up default values is to be safe even for input pins. I don't know HW details to that extend but that values can also change input behavior that's why having default is not a bad idea.

Maybe make sense to extend commit message to describe it better.

Thanks,
Michal


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help