Re: [PATCH v3 1/5] dt-bindings: spi: sun6i: add DT bindings for Allwinner R329/D1/R528/T113s SPI
From: Krzysztof Kozlowski <hidden>
Date: 2023-05-07 07:43:42
Also in:
linux-devicetree, linux-riscv, linux-spi, linux-sunxi, lkml
On 07/05/2023 06:06, Icenowy Zheng wrote:
在 2023-05-07星期日的 02:26 +0300，Maksim Kiselev写道：quoted
Listed above Allwinner SoCs has two SPI controllers. First is the regular SPI controller and the second one has additional functionality for MIPI-DBI Type C. Add compatible strings for these controllers Signed-off-by: Maksim Kiselev <redacted> --- .../devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml | 7 +++++++ 1 file changed, 7 insertions(+)diff --git a/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml b/Documentation/devicetree/bindings/spi/allwinner,sun6i- a31-spi.yaml index de36c6a34a0f..807dde457e3b 100644--- a/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml+++ b/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml@@ -21,6 +21,7 @@ properties:oneOf: - const: allwinner,sun6i-a31-spi - const: allwinner,sun8i-h3-spi + - const: allwinner,sun50i-r329-spi - items: - enum: - allwinner,sun8i-r40-spi@@ -28,6 +29,12 @@ properties:- allwinner,sun50i-h616-spi - allwinner,suniv-f1c100s-spi - const: allwinner,sun8i-h3-spi + - items: + - enum: + - allwinner,sun20i-d1-spi + - allwinner,sun20i-d1-spi-dbiIn this case I will prefer to list all 4 compatibles if backward compatibility is used: "allwinner,sun20i-d1-spi-dbi", "allwinner-sun20i-d1-spi", "allwinner,sun50i-r329-spi-dbi", "allwinner, sun50i-r329-spi", in case if we were gaining support for either quirks of D1 controller or SPI_DBI controllers.
I don't understand. If I see correctly, all four of them are specified. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel